Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): Support SQL Server for RDS proxy #25102

Merged
merged 9 commits into from
Apr 18, 2023

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Apr 13, 2023

Closes #22164

As stated in the issue the iam auth has a third option with the support for sql server. I did not add it in this pull request, because replacing the boolean property iamAuth with a string property would lead to breaking changes.
We should open up another issue for this and fix this separately.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 13, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 13, 2023 09:50
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@daschaa daschaa marked this pull request as ready for review April 13, 2023 11:50
@daschaa
Copy link
Contributor Author

daschaa commented Apr 13, 2023

Exemption Request: I think this needs no README entry :)

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 13, 2023
@corymhall corymhall added the pr-linter/exempt-readme The PR linter will not require README changes label Apr 18, 2023
corymhall
corymhall previously approved these changes Apr 18, 2023
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 18, 2023 12:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed corymhall’s stale review April 18, 2023 12:56

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6cd9f4a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2ea3e45 into aws:main Apr 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-rds: Support SQL Server for DatabaseProxies
3 participants