Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk-lib): compiled .js files are no longer being minified #25160

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

madeline-k
Copy link
Contributor

Prior to the aws-cdk repo remodel, there was a script executed at the end of build to minify the .js files. After the remodel, that script was excluded. In this change, I am adding it back in as a pre-package step. There is no need to perform this as part of the build. The minify-sources script takes about 2 seconds to run.

The size of aws-cdk-lib v 2.74 is 222 MB. This change will bring the overall size down to 205 MB.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@madeline-k madeline-k requested a review from a team April 17, 2023 18:34
@aws-cdk-automation aws-cdk-automation requested a review from a team April 17, 2023 18:34
@github-actions github-actions bot added the p2 label Apr 17, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@madeline-k madeline-k added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Apr 17, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of the pull request should omit 'aws-' from the name of modified packages. Use 'cdk-lib' instead of 'aws-cdk-lib'.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@madeline-k
Copy link
Contributor Author

The PR Linter should not be complaining for this one. I am working on updating that

@madeline-k
Copy link
Contributor Author

PR Linter change to unblock this PR: #25181

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 19, 2023 00:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1930395
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b53727f into main Apr 19, 2023
@mergify mergify bot deleted the madeline-k/minify-js branch April 19, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants