-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-cdk-lib): compiled .js files are no longer being minified #25160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
The PR Linter should not be complaining for this one. I am working on updating that |
PR Linter change to unblock this PR: #25181 |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Prior to the aws-cdk repo remodel, there was a script executed at the end of build to minify the
.js
files. After the remodel, that script was excluded. In this change, I am adding it back in as a pre-package step. There is no need to perform this as part of the build. Theminify-sources
script takes about 2 seconds to run.The size of aws-cdk-lib v 2.74 is 222 MB. This change will bring the overall size down to 205 MB.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license