Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pull alpine image from ecr public #25179

Merged
merged 2 commits into from
Apr 18, 2023
Merged

fix(core): pull alpine image from ecr public #25179

merged 2 commits into from
Apr 18, 2023

Conversation

corymhall
Copy link
Contributor

We still had one place where we are pulling an image from dockerhub which runs into docker rate limiting. Switching to an ecr public image instead.

fixes #24969


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We still had one place where we are pulling an image from dockerhub
which runs into docker rate limiting. Switching to an ecr public image
instead.

fixes #24969
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Apr 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 18, 2023 18:06
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@corymhall corymhall added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 18, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 18, 2023 18:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 74ae866
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6d906f8 into aws:main Apr 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Asset Staging): using docker image inside codebuild hits docker ratelimit
3 participants