Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk/aws-cloud9-alpha: support automaticStopTimeMinutes in Cloud9 Ec2Environment #25592

Closed
1 of 2 tasks
ba032759 opened this issue May 15, 2023 · 2 comments · Fixed by #25593
Closed
1 of 2 tasks

@aws-cdk/aws-cloud9-alpha: support automaticStopTimeMinutes in Cloud9 Ec2Environment #25592

ba032759 opened this issue May 15, 2023 · 2 comments · Fixed by #25593
Labels
@aws-cdk/aws-cloud9 Related to AWS Cloud9 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@ba032759
Copy link
Contributor

Describe the feature

Ec2Environment from @aws-cdk/aws-cloud9-alpha is missing the automaticStopTimeMinutes property, but CloudFormation has it: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloud9-environmentec2.html#cfn-cloud9-environmentec2-automaticstoptimeminutes

Use Case

I want to be able to directly set the time until auto hibernation on the construct without escape hatch.

Proposed Solution

The parameter can be passed through to CfnEnvironmentEC2 in the constructor.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.79.1

Environment details (OS name and version, etc.)

macOS 13.2.1
@ba032759 ba032759 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 15, 2023
@github-actions github-actions bot added the @aws-cdk/aws-cloud9 Related to AWS Cloud9 label May 15, 2023
@ba032759 ba032759 mentioned this issue May 15, 2023
Merged
@khushail
Copy link
Contributor

Thanks @ba032759 for mentioning this feature request and coming up with PR. Your efforts are appreciated. Our team would be happy to review this.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 15, 2023
@mergify mergify bot closed this as completed in 437345e Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloud9 Related to AWS Cloud9 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloud9): support setting automaticStopTimeMinutes ba032759/aws-cdk
2 participants
@ba032759 @khushail