Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch-alpha): tag instances launched from your managed CEs #25643

Merged
merged 6 commits into from
May 24, 2023
Merged

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented May 18, 2023

Tags.of() now applies to ComputeResources.Tags


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 18, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 18, 2023 20:32
@github-actions github-actions bot added the p2 label May 18, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 18, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review May 18, 2023 20:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 18, 2023
@comcalvi comcalvi marked this pull request as draft May 18, 2023 20:58
@comcalvi comcalvi marked this pull request as ready for review May 18, 2023 21:20
@comcalvi comcalvi added the @aws-cdk/aws-batch Related to AWS Batch label May 18, 2023
Copy link
Contributor

@otaviomacedo otaviomacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we achieve the same result by calling this new property tags (and relaying it to the tags property in the L1), so that users could use the Tags class?

Tags.of(computeEnvironment).add('key', 'value')

@comcalvi
Copy link
Contributor Author

comcalvi commented May 22, 2023

I can make this change this week 👍

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 24, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 43083ee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8498740 into main May 24, 2023
@mergify mergify bot deleted the tags branch May 24, 2023 17:20
@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-batch Related to AWS Batch contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants