Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awslint:physical-name-prop #2583

Closed
eladb opened this issue May 18, 2019 · 2 comments
Closed

awslint:physical-name-prop #2583

eladb opened this issue May 18, 2019 · 2 comments
Assignees
@eladb
Labels
p0 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Comments

@eladb
Copy link
Contributor

eladb commented May 18, 2019

Need a rule (and also update the guidelines): every AWS resource must have a single prop of type PhysicalName.
@fulghum fulghum added the p0 label Jun 10, 2019
@NGL321
Copy link
Contributor

NGL321 commented Aug 27, 2019

Was this fixed in #2972?

aws-cdk/tools/awslint/lib/rules/core-types.ts

Lines 116 to 118 in 3a0cde0

public get physicalNameClass() {
return this.sys.findClass(CoreTypesFqn.PhysicalName)
}

@NGL321 NGL321 added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 27, 2019
@skinny85
Copy link
Contributor

Yep, this is done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
p0 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fulghum @skinny85 @eladb @NGL321