Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codebuild): support for Docker Registry Image for Linux Arm #26121

Merged
merged 9 commits into from
Jul 18, 2023
Merged

feat(codebuild): support for Docker Registry Image for Linux Arm #26121

merged 9 commits into from
Jul 18, 2023

Conversation

sktan
Copy link
Contributor

@sktan sktan commented Jun 26, 2023 •
edited
Loading

Added support for usage of docker registry images when configuring CodeBuild Linux with ARM images

Closes #24367 and closes #24342

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 26, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 26, 2023 15:09
@sktan
Copy link
Contributor Author

sktan commented Jun 26, 2023

Build failed due to:

[Container] 2023/06/26 15:14:15 Phase complete: PRE_BUILD State: SUCCEEDED
[Container] 2023/06/26 15:14:15 Phase context status code:  Message: 
[Container] 2023/06/26 15:14:15 Entering phase BUILD
[Container] 2023/06/26 15:14:15 Running command /bin/bash ./build.sh --ci
=============================================================================================
installing...
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://registry.npmjs.org/string-width/-/string-width-4.2.3.tgz: write EPROTO 139877099177920:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1565:SSL alert number 40
".
info If you think this is a bug, please open a bug report with the information provided in "/codebuild/output/src808809037/src/github.com/aws/aws-cdk/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2023
@github-actions github-actions bot added bug This issue is a bug. and removed feature-request A feature should be added or improved. labels Jun 29, 2023
@mrgrain mrgrain changed the title feat(codebuild): Support for Docker Registry Image for Linux Arm CodeBuild feat(codebuild): support for Docker Registry Image for Linux Arm CodeBuild Jul 18, 2023
@mrgrain mrgrain changed the title feat(codebuild): support for Docker Registry Image for Linux Arm CodeBuild feat(codebuild): support for Docker Registry Image for Linux Arm Jul 18, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c8d4908
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f522796 into aws:main Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sktan sktan deleted the feat/aws-codebuild/dockerlinuxarmbuild branch July 18, 2023 23:36
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@sktan @bmoffatt
feat(codebuild): support for Docker Registry Image for Linux Arm (aws…
9585af9 
…#26121)

Added support for usage of docker registry images when configuring CodeBuild Linux with ARM images

Closes aws#24367 and closes aws#24342

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@BastiQ BastiQ mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
3 participants
@sktan @aws-cdk-automation @mrgrain