-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-cdk-lib): use new L1 codegen #26318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exempting from linter rules since passing all existing tests is proof this works. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
665519b
to
322f2e2
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
322f2e2
to
e1f906b
Compare
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Replaces the existing `cfn2ts` code generator with the new `spec2cdk` generator based on `@cdklabs/typewriter` and the separately published service spec database `@aws-cdk/aws-service-spec`. Other neccesary changes are: - Lowered coverage threshold for branches to 35% since the newly generated code is more expressive. Arguably we should not include generated files in the coverage calculation, but that's a bigger change. - Asset hashes in `cfn-include` test changed due to props now being ordered alphabetic. I've manually verified that the templates are otherwise identical. - Removing `port` property from `neptune-alpha` as this has been removed upstream and is not functional according to the service team. - Switched `synthetics-alpha` tests to use `testDeprecated()` for anything using the `Canary`. This is due to the removal of the `deleteLambdaResourcesOnCanaryDeletion` prop in the CFN spec. The new codegen marks removed props as deprecated. We will replace this feature with a custom resource soon. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Replaces the existing `cfn2ts` code generator with the new `spec2cdk` generator based on `@cdklabs/typewriter` and the separately published service spec database `@aws-cdk/aws-service-spec`. Other neccesary changes are: - Lowered coverage threshold for branches to 35% since the newly generated code is more expressive. Arguably we should not include generated files in the coverage calculation, but that's a bigger change. - Asset hashes in `cfn-include` test changed due to props now being ordered alphabetic. I've manually verified that the templates are otherwise identical. - Removing `port` property from `neptune-alpha` as this has been removed upstream and is not functional according to the service team. - Switched `synthetics-alpha` tests to use `testDeprecated()` for anything using the `Canary`. This is due to the removal of the `deleteLambdaResourcesOnCanaryDeletion` prop in the CFN spec. The new codegen marks removed props as deprecated. We will replace this feature with a custom resource soon. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mrgrain any good reason why removing the port support is a necessity? We use it and want to be able to customize neptune port, IMHO changing such functionality without backward compatibility damages Netpune credibility and functionality. |
Hey @bissli82 Thanks for reaching out! Looks like Neptune now offers a replacement Please also note that |
Thanks! |
Replaces the existing
cfn2ts
code generator with the newspec2cdk
generator based on@cdklabs/typewriter
and the separately published service spec database@aws-cdk/aws-service-spec
.Other neccesary changes are:
cfn-include
test changed due to props now being ordered alphabetic. I've manually verified that the templates are otherwise identical.port
property fromneptune-alpha
as this has been removed upstream and is not functional according to the service team.synthetics-alpha
tests to usetestDeprecated()
for anything using theCanary
. This is due to the removal of thedeleteLambdaResourcesOnCanaryDeletion
prop in the CFN spec. The new codegen marks removed props as deprecated. We will replace this feature with a custom resource soon.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license