feat(appconfig): L2 constructs #26639
Conversation
github-actions
bot
added
p2
beginning-contributor
aws-cdk-automation
added
the
pr/needs-community-review
| * @param growthFactor The growth factor of the strategy | ||
| * @param deploymentDuration The duration of the deployment | ||
| */ | ||
| public static linear(growthFactor: number, deploymentDuration: Duration, finalBakeTime?: Duration): RolloutStrategy { |
There was a problem hiding this comment.
One final thing: please change this signature to receive a data structure, instead of three separate parameters. This is especially important in this case, where we have two arguments of the same type, which tends to confuse users.
aws-cdk-automation
removed
the
pr/needs-community-review
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds a set of L2s to appconfig. For more information, see the RFC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license