Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-autoscaling/cfn-resource-policy): (maxBatchSize is 100 which is too small, we want maxBatchSize dynamically update by ASG size) #26663

Closed
2 tasks
chensy-aws opened this issue Aug 7, 2023 · 4 comments
Labels
needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@chensy-aws
Copy link

Describe the feature

Since most ASG scale with percentage of instance in use. So it is make more sense to use maxBatchSizeInPercentage instead of just maxBatchSize.

Also, the maxBatchSize upper limit is 100 which is still small in our usage, we have a ASG with more than 4000+ instance and 10% can be replace at a time. So request to increase the upper limit

Use Case

When RollingUpdate a large ASG, the update time is too long which decrease the deployment quite a lot

Proposed Solution

Introduce maxBatchSizeInPercentage as on RollingUpdate policy and increase the upper limit for maxBatchSize.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.73

Environment details (OS name and version, etc.)

AL2

@chensy-aws chensy-aws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2023
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Aug 7, 2023
@chensy-aws
Copy link
Author

This greatly impact our prod pipeline deployment speed when we need a RollingUpdate.

@chensy-aws chensy-aws changed the title (cfn-resource-policy): (maxBatchSize is 100 which is too small, we want maxBatchSize dynamically update by ASG size) (aws-autoscaling/cfn-resource-policy): (maxBatchSize is 100 which is too small, we want maxBatchSize dynamically update by ASG size) Aug 7, 2023
@peterwoodworth
Copy link
Contributor

CfnResourcePolicy in Autoscaling? Could you please link to the API reference page of the construct you are referring to?

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed feature-request A feature should be added or improved. @aws-cdk/aws-iam Related to AWS Identity and Access Management labels Aug 7, 2023
@peterwoodworth
Copy link
Contributor

OK I see https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.CfnAutoScalingRollingUpdate.html

This is handled by CloudFormation, we just create the template. Please report this issue at the CloudFormation Coverage Roadmap, CDK will automatically support this when CloudFormation does.

@peterwoodworth peterwoodworth added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants