Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): set default spot allocation strategy to SPOT_PRICE_CAPACITY_OPTIMIZED #26731

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

comcalvi
Copy link
Contributor

https://aws.amazon.com/about-aws/whats-new/2023/08/aws-batch-price-capacity-optimized-allocation-strategy-spot-instances/ and https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-fleet-allocation-strategy.html

SPOT_PRICE_CAPACITY_OPTIMIZED is now recommended over SPOT_CAPACITY_OPTIMIZED; make it the new default, while the construct is still in alpha.

BREAKING CHANGE: if using spot instances on your Compute Environments, they will default to SPOT_PRICE_CAPACITY_OPTIMIZED instead of SPOT_CAPACITY_OPTIMIZED now.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 11, 2023 22:42
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 11, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 12, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6d9b96a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e0ca252 into main Aug 12, 2023
11 checks passed
@mergify mergify bot deleted the comcalvipriceCapacityOptimized branch August 12, 2023 00:59
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants