Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_elasticloadbalancingv2: documentation update needed for CfnLoadBalancer regarding Security Groups #26799

Closed
unirt opened this issue Aug 18, 2023 · 3 comments
Assignees
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 documentation This is a problem with documentation. p2

Comments

@unirt
Copy link

unirt commented Aug 18, 2023

Describe the issue

In the AWS CDK documentation for class CfnLoadBalancer (construct), the security group description reads:
[Application Load Balancers] The IDs of the security groups for the load balancer.
However, in the AWS CloudFormation documentation, it is stated as:
[Application Load Balancers and Network Load Balancers] The IDs of the security groups for the load balancer.
It seems that the CDK documentation might not be updated to reflect that the security groups also apply to NLB in addition to ALB.
Can we get this documentation updated to ensure clarity and consistency with CloudFormation's documentation? Thanks.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticloadbalancingv2.CfnLoadBalancer.html

@unirt unirt added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2023
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Aug 18, 2023
@peterwoodworth
Copy link
Contributor

This all happens in an automatic process. Either this is a recent change, or the process is blocked for this package for some reason. Regardless, I don't think I can give a timeline here, but thanks for letting us know.

@peterwoodworth peterwoodworth added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2023
@tim-finnigan tim-finnigan self-assigned this Mar 14, 2024
@tim-finnigan
Copy link

It looks like https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_elasticloadbalancingv2.CfnLoadBalancer.html has since been updated to reflect the requested change, so I'll go ahead and close this issue.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 documentation This is a problem with documentation. p2
Projects
None yet
Development

No branches or pull requests

3 participants