-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigateway): set RestApi CloudWatchRole and Account retention policy #26836
Conversation
… Account retention policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, but it should be not allowed to pass cloudWatchRoleRemovalPolicy
if cloudWatchRole == false
.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds a
cloudWatchRoleRemovalPolicy
property toRestApiBaseProps
that allows to specify a custom retention policy for CloudWatchRole and Account.Defaults to
RemovalPolicy.RETAIN
.Closes #26827.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license