-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3): bucket deletion fails if object creation races against cleanup #26875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Clarification Request: As a new contributor, the requirements for integration testing were unclear to me. I have tested the policy on my own buckets and included unit tests, but am willing to work toward code compliance with assistance. |
This document should be mostly accurate explaining what they are and how they should be run. You don't need to add a new one, but you probably will need to update some existing snapshots. You'll need AWS account credentials to run the actual tests in. The tests are in |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
@miles-po Thanks for this! Are you still interested in wrapping this up? If you can get the unit tests passing and update the integration test snapshots with |
Family's been ill, so I've been playing catch-up. I started working on it again late yesterday. Was hoping to finish up today. |
@mrgrain I added some fixes including unit test repair. I keep getting an integration test failure in the ![]() |
And after fixing one set of unit tests, I broke another. Lemme fix that before I ask for more help. (Oops!) |
@mrgrain Made my fixes. Appears to me the only failures are now snapshot failures. Been trying to get the integration tests to work in a sandbox account, following the contributors instructions as close as I know how, but nothing I try seems to work. If they work for you, I owe you a beverage of your choice for getting the snapshots to work. If not, I'm here to help with the code debugging process and answer any questions I can. |
@mrgrain I didn't run
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds a DENY policy for S3:PutObject on buckets to be auto-deleted to prevent a race condition on emptying with external bucket writers.
As a new contributor, the requirements for integration testing were unclear to me. I have tested the policy on my own buckets and included unit tests, but am willing to work toward code compliance with assistance.
Closes #26874.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license