Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker-Domains: "Suggested code repositories for the domain" cannot be set #26993

Closed
ttais2017 opened this issue Sep 4, 2023 · 2 comments
Closed
Labels
bug This issue is a bug. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. package/tools Related to AWS CDK Tools or CLI

Comments

@ttais2017
Copy link

ttais2017 commented Sep 4, 2023

Describe the bug

The Builder of "CfnDomain" does not have a property for setting the "suggested code repositories" of the domain is being created.

image

Expected Behavior

The Domain Builder includes a property for setting the "suggested code repositories"

Current Behavior

The Builder of "CfnDomain" does not have a property for setting the "suggested code repositories" of the domain is being created.

image

Here the current API:

image

As can be set, the "Environment"-tab does not have a related property within the Domain Builder.

Reproduction Steps

The Builder of "CfnDomain" does not have a property for setting the "suggested code repositories" of the domain is being created.

image

Possible Solution

extend the current Domain Builder with the property for setting the suggested code repositories

Additional Information/Context

No response

CDK CLI Version

aws-cli/2.13.12 Python/3.11.4 Windows/10 exe/AMD64 prompt/off

Framework Version

No response

Node.js Version

9.5.1

OS

Windows

Language

Java

Language Version

Java 17

Other information

No response

@ttais2017 ttais2017 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Sep 4, 2023
@peterwoodworth
Copy link
Contributor

This is an L1 CloudFormation resource, so if you need more functionality, then you'll need to reach out to CloudFormation at the CloudFormation Coverage Roadmap. If this is available in CloudFormation and is not yet available in CDK, then there's an automatic process for that and it will be in shortly from whenever it's introduced to CloudFormation.

@peterwoodworth peterwoodworth added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

2 participants