Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): Different --concurrency for different resources (config) #27080

Open
2 tasks
MaximilianSchon opened this issue Sep 9, 2023 · 1 comment
Open
2 tasks
Labels
cli Issues related to the CDK CLI effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@MaximilianSchon
Copy link

Describe the feature

A configuration where you can adjust the concurrency based on what cloudformation resource is created.

Use Case

Different CloudFormation resources have different rate limitations and since CloudFormation is not retrying automatically on 429 status codes (at all times at least), e.g.

aws-cloudformation/cloudformation-coverage-roadmap#1095
#15573

A solution to this would be to have a lower concurrency when the underlying cloudformation has a lower request rate.

Proposed Solution

No response

Other Information

I realize that the underlying problem is not CDK but CloudFormation, but CDK could possibly introduce a default concurrency for different resources, which in turn would allow us to deploy all stacks concurrently, which would immensely speed up deployment times.

I have been using no concurrency for my deployments to circumvent this issue, but recently raised it to 25 for one deployment where I was affecting ~100 stacks but knew that I was not touching ApiGateway and the deployment time was about 5-10 times quicker than it would have been without concurrency. Having CDK work out reasonable rates for concurrency inherently (or make the user able to configure them) would make the CDK experience a lot better.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.84.0

Environment details (OS name and version, etc.)

Windows 11

@MaximilianSchon MaximilianSchon added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 9, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Sep 9, 2023
@indrora indrora added p2 needs-discussion This issue/PR requires more discussion with community. needs-design This feature request needs additional design work. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2023
@indrora
Copy link
Contributor

indrora commented Sep 11, 2023

That's a lotta stacks!

Adding needs-design since there's a lot of possible edge cases that have to be taken into consideration.

@peterwoodworth peterwoodworth added effort/large Large work item – several weeks of effort and removed needs-discussion This issue/PR requires more discussion with community. needs-design This feature request needs additional design work. labels Sep 18, 2023
@pahud pahud added the cli Issues related to the CDK CLI label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues related to the CDK CLI effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

4 participants