Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synthetics): include auto-delete-underlying-resources in package #27096

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Sep 11, 2023

The source code in custom-resource-handlers was not included in the npm pack and thus unavailable to customers. This PR includes it. Tested by running npm pack and confirming its existence and also testing it the resulting package on a local cdk app.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2023 14:45
@kaizencc kaizencc added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Sep 11, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 11, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fe8f312
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5046a9b into main Sep 11, 2023
29 checks passed
@mergify mergify bot deleted the conroy/fixsyn branch September 11, 2023 15:09
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
…27096)

The source code in `custom-resource-handlers` was not included in the `npm pack` and thus unavailable to customers. This PR includes it. Tested by running `npm pack` and confirming its existence and also testing it the resulting package on a local cdk app.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants