Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: Breaking change in v2.96.0 - from_ecr_repository() got an unexpected keyword argument 'tag' #27139

Closed
adam-kiss-sg opened this issue Sep 14, 2023 · 3 comments
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@adam-kiss-sg
Copy link

adam-kiss-sg commented Sep 14, 2023

Describe the bug

Our CI/CD pipeline using cdk with python started reporting an error: TypeError: from_ecr_repository() got an unexpected keyword argument 'tag'

Expected Behavior

No error.

Current Behavior

TypeError: from_ecr_repository() got an unexpected keyword argument 'tag'

Reproduction Steps

use

ecs.ContainerImage.from_ecr_repository(
                        repository=repo,
                        tag=image_tag,
                    )

Possible Solution

Please revert this change: 9f07911 , because this is a breaking change.

Additional Information/Context

No response

CDK CLI Version

2.96.0

Framework Version

No response

Node.js Version

irrelevant

OS

irrelevant

Language

Python

Language Version

irrelevant

Other information

No response

@adam-kiss-sg adam-kiss-sg added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 14, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Sep 14, 2023
@Annegies
Copy link

Annegies commented Sep 14, 2023

I also encountered this issue, would have expected it to be backwards compatible

@colifran
Copy link
Contributor

This is closed with #27143 which reverts this change.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants