Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(apigatewayv2-integrations): Specify AWS type integration on WebSocketLambdaIntegration #27150

Closed
2 tasks
peterwoodworth opened this issue Sep 14, 2023 · 4 comments
Closed
2 tasks

(apigatewayv2-integrations): Specify AWS type integration on WebSocketLambdaIntegration #27150

peterwoodworth opened this issue Sep 14, 2023 · 4 comments
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@peterwoodworth
Copy link
Contributor

Describe the feature

Currently this is not possible without escape hatches, since it will always set it to AWS_PROXY

aws-cdk/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha/lib/websocket/lambda.ts

Line 48 in dc87d28

type: WebSocketIntegrationType.AWS_PROXY,

Use Case

It appears to be valid configuration looking at Cfn docs, someone asked how to accomplish this in this discussion

Proposed Solution

Add new prop to WebSocketLambdaIntegration

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

mac
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort labels Sep 14, 2023
@JobaDiniz
Copy link

It's not a lambda integration. I do not need to define any lambda. It's a direct integration from WebSocket to an AWS service, like step function.
WebSocket to call Step Function directly, without requiring lambda.

@peterwoodworth
Copy link
Contributor Author

OK, feel free to create a feature request for a high level pattern that you would like to see supported 🙂

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@JobaDiniz
Copy link

Created a detailed enhancement request here: #27164

@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JobaDiniz @peterwoodworth