(ec2.CfnNetworkAclEntry): Invalid links to CloudFormation documentation

[hikarunakatani]

Describe the issue

The CloudFormation documentation links embedded in the ec2.CfnNetworkAclEntry seem to be invalid and redirect to user guide page of Cloudformation.

class CfnNetworkAclEntry (construct) · AWS CDK
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.CfnNetworkAclEntry.html

Example link

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-networkaclentry.html#cfn-ec2-networkaclentry-networkaclid

The correct link should be like this:

http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-network-acl-entry.html#cfn-ec2-networkaclentry-networkaclid

Links

class CfnNetworkAclEntry (construct) · AWS CDK
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.CfnNetworkAclEntry.html

[khushail]

Hi @hikarunakatani , thanks for reaching out. Yes, this should be corrected.

[peterwoodworth]

The correct URL has been in the spec source for a while now. So, this seems to be on our end

aws-cdk/packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/000_official/000_AWS_EC2.json

Line 6965 in c695b60

"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-network-acl-entry.html",

It seems to be an issue with cfnspec rather than just the docs. You can see the same incorrect docs link in the generated type file

export declare namespace CfnNetworkAclEntry {
    /**
     * Describes a range of ports.
     *
     * @struct
     * @stability external
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-networkaclentry-portrange.html
     */

I'm not sure where this is handled. Since the link that it displays used to be what was in the CfnSpec, I suspect it failed to update for some reason.