Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-msk-alpha: edit cluster config will cause cluster recreation #27173

Closed
leo-li-wcq opened this issue Sep 18, 2023 · 3 comments
Closed

aws-msk-alpha: edit cluster config will cause cluster recreation #27173

leo-li-wcq opened this issue Sep 18, 2023 · 3 comments
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) bug This issue is a bug. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2

Comments

@leo-li-wcq
Copy link

Describe the bug

After editing the server properties for the cluster Config, the clusterConfig does not update in place, it will create a new cluster and delete the existing cluster.

this.clusterConfig = new CfnConfiguration(this, 'kafka-cluster-config', { name:${clusterName}-kafka-config, serverProperties: kafkaClusterConfigOptionsToEnable ? generateClusterConfig( kafkaClusterConfigOptionsToEnable ) : '' });

Expected Behavior

After editing the server properties for the cluster Config, the clusterConfig should update in place and not cause cluster recreation.

Current Behavior

Editing cluster config will cause cluster recreation.

Reproduction Steps

  1. Create a new cluster.
  2. Modify values in serverProperties.
  3. Run CDK against the existing stack, it will trigger cluster recreation.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.93.0 (build 724bd01)

Framework Version

No response

Node.js Version

v18.17.1.

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response

@leo-li-wcq leo-li-wcq added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 18, 2023
@github-actions github-actions bot added the @aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) label Sep 18, 2023
@peterwoodworth
Copy link
Contributor

If your diff is only showing changes to ServerProperties, then this seems misdocumented or bugged on CloudFormation's end. Cloudformation is seeing the changes in the template and they are the ones doing resource replacement, we're just creating the template.

@peterwoodworth peterwoodworth added p2 needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 18, 2023
@leo-li-wcq
Copy link
Author

Thanks @peterwoodworth We got it fixed, not related to the cluster Config, it's actually a code change in the cluster name, closing this issue.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-msk Related to Amazon Managed Streaming for Apache Kafka (Amazon MSK) bug This issue is a bug. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2
Projects
None yet
Development

No branches or pull requests

2 participants