Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli-lib-alpha needs a framework for integration testing setup #27192

Closed
mrgrain opened this issue Sep 19, 2023 · 4 comments
Closed

cli-lib-alpha needs a framework for integration testing setup #27192

mrgrain opened this issue Sep 19, 2023 · 4 comments
Labels
cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 testing Related to tests needed to be modified or added.

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Sep 19, 2023 •
edited
Loading

Currently cli-lib-alpha is only unit tested.
Need to add at least one example for an integration test.
We have various approach to this in the @aws-cdk-testing namespace, one of them will work.
@mrgrain mrgrain self-assigned this Sep 19, 2023
@mrgrain mrgrain changed the title testing framework for cli-lib cli-lib-alpha needs a framework for integration testing setup Sep 19, 2023
@msambol
Copy link
Contributor

msambol commented Sep 19, 2023

@mrgrain I can take this.

@mrgrain mrgrain added p2 cli Issues related to the CDK CLI testing Related to tests needed to be modified or added. and removed p1 labels Sep 19, 2023
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
@tim-finnigan tim-finnigan added feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort labels Mar 14, 2024
@mrgrain mrgrain removed their assignment Jul 26, 2024
@mrgrain
Copy link
Contributor Author

mrgrain commented Nov 6, 2024

Basic system has been implemented: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli-lib.integtest.ts

We will likely move to just use the cli lib eventually.

@mrgrain mrgrain closed this as completed Nov 6, 2024
@mrgrain
Copy link
Contributor Author

mrgrain commented Nov 6, 2024

Basic system has been implemented: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli-lib.integtest.ts

We will likely move to just use the cli lib eventually.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 testing Related to tests needed to be modified or added.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrgrain @msambol @peterwoodworth @tim-finnigan