feat(scheduler): disable Schedule on creation #27236
Conversation
github-actions
bot
added
the
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request Not sure what to add to the README file for this change. Also I think integration test is not required here (yet)? |
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Thanks for the contribution! 💪
I left you a couple of comments for some minor changes.
README changes
You can specify your new attribute in the related README.
For example, adding a new section Disabling Schedules after Grouping Schedules explaining how to use the attribute and the default behavior (with an example).
Integration test
You should be able to implement an integration test in the test folder of the construct by following the specified guidelines.
|
Thanks for your feedback! I did the proposed code changes, and updated the README file. I will now work on adding the integration test and will update this PR once done. |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
There was a problem hiding this comment.
Thanks for your contribution @MoartnW! This looks good to me. However, here's a quick PSA: please create open-source PRs off of a non-main branch, so we're guaranteed to have permission to push to your branch. I'm unsure if it will work this time but we're going to give it a try.
More information here
kaizencc
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Small change to make it possible to disable a Schedule. It basically works the same as in Rule in aws-events.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license