Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-batch): Implement LogConfigurationProperty with awslogs per default in EcsJobDefinition #27308

Closed
2 tasks
gmarchand opened this issue Sep 27, 2023 · 3 comments
Closed
2 tasks

(aws-batch): Implement LogConfigurationProperty with awslogs per default in EcsJobDefinition #27308

gmarchand opened this issue Sep 27, 2023 · 3 comments
Labels
@aws-cdk/aws-batch Related to AWS Batch feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@gmarchand
Copy link

Describe the feature

Today every AWS Batch Job Definition created with CDK has no logging configuration.

image

Use Case

A container of a AWS Batch job failed with this message :

"Reason
CannotStartContainerError: Error response from daemon: failed to create shim task: OCI runtime create failed: unable to retrieve OCI runtime error (open /run/containerd/io.containerd.runtime.v2.task/moby/0534f9b15a9e102dac0012fc03becb4279027afd7f6419df578"

I can't debug without the logging configuration enabled.

FYI : Logging data is displayed in "Job logs" when the job status is RUNNING. So there's no point for this use case

Proposed Solution

enable per default awslogsawslogs as described in this interface aws_cdk.aws_batch.CfnJobDefinition.LogConfigurationProperty
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_batch.CfnJobDefinition.LogConfigurationProperty.html

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.96.2

Environment details (OS name and version, etc.)

All OS
@gmarchand gmarchand added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 27, 2023
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Sep 27, 2023
@gmarchand gmarchand changed the title aws-batch: Implement LogConfigurationProperty with awslogs per default in EcsJobDefinition (aws-batch): Implement LogConfigurationProperty with awslogs per default in EcsJobDefinition Sep 27, 2023
@peterwoodworth
Copy link
Contributor

Is the request just to make this the default? You can configure logging on your containers with our L2 constructs.

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 27, 2023
@gmarchand
Copy link
Author

Sorry for the confusion, I don't understand something ...

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-batch Related to AWS Batch feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmarchand @peterwoodworth