fix: load time speed has regressed #27314
Conversation
The check we needed to perform was inverted
rix0rrr
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
force-pushed
the
huijbers/oops-lazify
branch
from
a0d0748 to
4f3f9b5
Compare
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
rix0rrr
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
changed the title
rix0rrr
changed the title
This is a follow-up to #27217 The check we needed to perform was inverted 😖 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is a follow-up to #27217 The check we needed to perform was inverted 😖 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is a re-roll of #27217 which had to be reverted (first attempt to fix forward in #27314, then reverted in #27353). The issue with the previous change were: - The mutation was accidentally switched off at the last second. - It did not work for ESM modules, because the code were were generating was not recognized as a CommonJS export by `cjs-module-lexer`. We now generate code that passes the `cjs-module-lexer`, and have tests in place to prove it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is a follow-up to #27217
The check we needed to perform was inverted 😖. We got rid of the explicit
lazy-index.ts, but because the script didn't actually transform any files this made the load speed worse instead of better.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license