Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lambda-python-alpha: Default Bundling File Access is not correct. #27352

Open
animateM opened this issue Sep 29, 2023 · 1 comment
Open
Labels
@aws-cdk/aws-lambda-python bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@animateM
Copy link

Describe the bug

The problem is simple. The default BundlingFileAccess is NOT set to BundlingFileAccess.VOLUME_COPY. Instead, it is set to BIND_MOUNT.

I understand this was done for performance, but compatability beats performance. Everyone using docker-in-docker via vscode .devcontainers gets errors during the build process. That is a lot of people spending hours trying to figure out strange file permission errors.

Expected Behavior

The default should be set to BundlingFileAccess.VOLUME_COPY.

Current Behavior

The default is set to BIND_MOUNT which does not cover many developers dev environment.

Reproduction Steps

This problem occurs in any docker-in-docker. It is even mentioned in a README.md somewhere.

Possible Solution

Change the default in bundling.ts, or even in core.

Additional Information/Context

In essence, docker-in-docker is a popular way to work via vscode. It is popular enough that the BundleFileAccess option default needs to be changed.

CDK CLI Version

2.96.2 (build 3edd240)

Framework Version

No response

Node.js Version

v20.7.0

OS

CentOS

Language

Python

Language Version

Python 3.10

Other information

No response

@animateM animateM added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 29, 2023
@khushail
Copy link
Contributor

khushail commented Sep 29, 2023

Hi @animateM , thanks for reaching out.

As the documentation here states the alternate for docker based bundling in complex situation like yours, I am marking this issue as a P2

However, we use +1s to help prioritize our work, and are happy to re-evaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-python bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants