feat(aws-cdk-lib): reduce JavaScript load time, second attempt #27362
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
This change halves the load time of `require('aws-cdk-lib')`, from ~600ms to ~300ms on my machine. It also shaves ~8min off running all integ tests (again, on my machine).
It does this by making all loading of JavaScript modules lazy, so they are only loaded just before any symbols from them are actually accessed (instead of loading all modules at startup). This new automatic module replaces the previous manual effort to do something similar, in `lazy-index.ts`.
Note that this transformation (unfortunately) does not affect TypeScript compilation times: the TypeScript compiler is still going to read all `.d.ts` files. To improve interactive TypeScript performance, use `swc` or `ts-node` with type checking disabled. Fully type checking your application using `tsc` will take the amount of time it takes.
Turning this:
```js
const x = require("x");
module.exports.banana = function() {
return x.hello();
}
```
Into this:
```js
var x = () => { var tmp = require("x"); x = () => tmp; return tmp; };
module.exports.banana = function () {
return x().hello();
};
```
rix0rrr
force-pushed
the
huijbers/lazify-2
branch
from
9837489 to
b034f08
Compare
rix0rrr
added
pr-linter/exempt-readme
rix0rrr
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This is a re-roll of #27217 which had to be reverted (first attempt to fix forward in #27314, then reverted in #27353).
The issue with the previous change were:
cjs-module-lexer.We now generate code that passes the
cjs-module-lexer, and have tests in place to prove it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license