feat(msk-alpha): MSK Kafka versions 2.8.2.tiered and 3.5.1 and StorageMode property #27560
Conversation
github-actions
bot
added
feature-request
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
chrispidcock
changed the title
chrispidcock
changed the title
github-actions
bot
added
the
effort/small
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Hello @lpizzinidev , I was wondering if you could please give me any advice on getting this PR reviewed by a maintainer. Is there anything further you could recommend I contribute or add to this PR? Thank you for all your previous work to review my code! Thanks |
|
Hi @chrispidcock |
There was a problem hiding this comment.
Thanks for opening this PR @chrispidcock and for reviewing @lpizzinidev. A couple of things:
- I am approving this PR, but ideally these would be separated out into two different PRs since they introduce two completely separate features. There are a few benefits to this approach -- faster/easier reviews, each feature shows up individually in our changelog, etc. I am allowing this because it is already done. @lpizzinidev if you see something like this in a future PR you review, feel free to ask for a separation.
- We won't be able to release this until after re:invent. Apologies there. Just want to make sure you're aware of the timeline @chrispidcock.
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
chrispidcock
force-pushed
the
adding-new-msk-kafka-versions
branch
from
08feb95 to
e94f72c
Compare
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
1 similar comment
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
@kaizencc Hello, I had some issues post your code review, and I was wondering if you could review again, please, as I had to make a change to satisfy the tests. Thank you. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you everyone for your help to get this through. |
…eMode property (aws#27560) This patch adds support for the `tiered` `storage mode` and Kafka versions `2.8.2.tiered` & `3.5.1` in the `aws-msk-alpha` package. --- ### Changes - added Kafka versions `2.8.2.tiered` & `3.5.1`. - added `storageMode` L1 construct property to the L2 msk - added unit and integ tests for `Kafka versions and 'storageMode` - updated test versions to latest supported Kafka version as desired Ref: - [aws: MSK supported Kafka versions](https://docs.aws.amazon.com/msk/latest/developerguide/supported-kafka-versions.html) --- Closes aws#27551 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This patch adds support for the
tieredstorage modeand Kafka versions2.8.2.tiered&3.5.1in theaws-msk-alphapackage.Changes
2.8.2.tiered&3.5.1.storageModeL1 construct property to the L2 mskKafka versions and 'storageModeRef:
Closes #27551
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license