feat(secretsmanager): validate maximum value of automaticallyAfter in RotationSchedule #27592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llyAfter for RotationSchedule
github-actions
bot
added
the
admired-contributor
aws-cdk-automation
added
the
pr/needs-maintainer-review
kaizencc
changed the title
kaizencc
changed the title
kaizencc
added
pr-linter/exempt-readme
kaizencc
changed the title
kaizencc
previously approved these changes
Oct 18, 2023
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
scanlonp
approved these changes
Oct 18, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a validation for whether
automaticallyAfterinRotationScheduleis not greater than 1000 days.We discussed in the following threads.
#27570 (review)
#27570 (review)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license