Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduler-targets-alpha): SnsPublish scheduler target #27838

Merged
merged 24 commits into from
Nov 29, 2023
Merged

feat(scheduler-targets-alpha): SnsPublish scheduler target #27838

merged 24 commits into from
Nov 29, 2023

Conversation

ymhiroki
Copy link
Contributor

@ymhiroki ymhiroki commented Nov 4, 2023

Closes #27459

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Nov 4, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 4, 2023 15:04
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Nov 4, 2023
@ymhiroki ymhiroki changed the title Scheduler targets snspublish feat(scheduler-targets): SnsPublish scheduler target Nov 4, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 4, 2023
lpizzinidev
lpizzinidev suggested changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
Looks good, just a note on unit tests for imported topics.

I missed that you were working on this as well so I opened a duplicate PR.
I will close mine, your integration test is cleaner 😄

packages/@aws-cdk/aws-scheduler-targets-alpha/test/sns-publish.test.ts Outdated Show resolved Hide resolved
@lpizzinidev lpizzinidev mentioned this pull request Nov 5, 2023
Closed
@ymhiroki
Copy link
Contributor Author

ymhiroki commented Nov 7, 2023 •
edited
Loading

Thanks 👍 Looks good, just a note on unit tests for imported topics.

I missed that you were working on this as well so I opened a duplicate PR. I will close mine, your integration test is cleaner 😄

@lpizzinidev
Thanks for the review and kind comments!

lpizzinidev
lpizzinidev suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and the extra unit test for coverage 👍
Just two minor adjustments and it will be good to go for me.

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/index.ts Outdated
@@ -1,4 +1,5 @@
export * from './target';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please sort these alphabetically?

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/sns-publish.ts Outdated
export class SnsPublish extends ScheduleTargetBase implements IScheduleTarget {
constructor(
private readonly topic: sns.ITopic,
private readonly props: ScheduleTargetBaseProps,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private readonly props: ScheduleTargetBaseProps,
private readonly props: ScheduleTargetBaseProps = {},

Let's add a default value to simplify initialization when no props are needed.
Can you please then update all the SnsPublish(topic, {}) to SnsPublish(topic) in this PR?

Copy link
Contributor Author

@ymhiroki ymhiroki Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice! I've updated them.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 9, 2023
Hiroki Yamazaki added 2 commits November 9, 2023 12:57
@ymhiroki ymhiroki requested a review from lpizzinidev November 9, 2023 13:30
lpizzinidev
lpizzinidev approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 9, 2023
sumupitchayan
sumupitchayan previously approved these changes Nov 17, 2023
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 17, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed sumupitchayan’s stale review November 19, 2023 13:28

Pull request has been modified.

@ymhiroki
Copy link
Contributor Author

I update the branch and re-run the CI since Queue: Embarked in merge queue is failed due to the permission and Rule: automatic merge (queue) is skipped.

@ymhiroki
Copy link
Contributor Author

@sumupitchayan
AWS CodeBuild CI failed with an error:

[Container] 2023/11/19 13:31:00.960051 Running command npm config set unsafe-perm true
npm ERR! `unsafe-perm` is not a valid npm option

Do you have any ideas to fix this error? It seems to be happening in other Pull Requests too.

@lpizzinidev
Copy link
Contributor

@ymhiroki
The core team is working on it.
A fix will likely be released next week.

@ymhiroki
Copy link
Contributor Author

@ymhiroki The core team is working on it. A fix will likely be released next week.

Thanks for the briefing! I wait for it.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 23, 2023
@vinayak-kukreja vinayak-kukreja changed the title feat(scheduler-targets): SnsPublish scheduler target feat(scheduler-targets-alpha): SnsPublish scheduler target Nov 28, 2023
vinayak-kukreja
vinayak-kukreja approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ymhiroki , apologies for the delay. Really appreciate you adding this contribution to cdk.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@vinayak-kukreja vinayak-kukreja self-assigned this Nov 29, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c86928b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ff203a1 into aws:main Nov 29, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this pull request Dec 5, 2023
@ymhiroki @chenjane-dev
feat(scheduler-targets-alpha): SnsPublish scheduler target (aws#27838)
670fb61 
Closes aws#27459 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@sumupitchayan sumupitchayan Awaiting requested review from sumupitchayan

Assignees

@vinayak-kukreja vinayak-kukreja

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-scheduler-targets-alpha): Add SnsPublish Target
5 participants
@ymhiroki @lpizzinidev @aws-cdk-automation @sumupitchayan @vinayak-kukreja