feat(appconfig-alpha): add deploy method to configuration constructs #28269
Conversation
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
github-actions
bot
added
valued-contributor
|
|
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Thanks!
Just some minor nits.
Also, can you please close #28174 in favor of this?
| @@ -176,6 +176,20 @@ new appconfig.HostedConfiguration(this, 'MyHostedConfiguration', { | |||
| }); | |||
| ``` | |||
|
|
|||
| To deploy a configuration to an environment after initialization use the `deployTo` method: | |||
There was a problem hiding this comment.
| To deploy a configuration to an environment after initialization use the `deployTo` method: | |
| To deploy a configuration to an environment after initialization use the `deploy` method: |
| const app = new Application(stack, 'MyAppConfig', { | ||
| name: 'MyApplication', | ||
| }); | ||
| app.addEnvironment('MyEnv1'); |
There was a problem hiding this comment.
| app.addEnvironment('MyEnv1'); |
no environment associated
Shouldn't this be removed?
There was a problem hiding this comment.
Those are being attached to the application and not the configuration :)
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
vinayak-kukreja
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adding a deploy method to the configuration construct to allow deployments on a config at any time after creation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license