Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs-patterns): ApplicationMultipleTargetGroupsEc2Service ignores load balancer name #28394

Merged
merged 4 commits into from
Dec 26, 2023
Merged

fix(ecs-patterns): ApplicationMultipleTargetGroupsEc2Service ignores load balancer name #28394

merged 4 commits into from
Dec 26, 2023

Conversation

lpizzinidev
Copy link
Contributor

Fixes by adding the loadBalancerName property to the generated ApplicationLoadBalancer.

Closes #23535.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2023 16:11
@lpizzinidev lpizzinidev force-pushed the gh-23535 branch 2 times, most recently from 0b18fa5 to 8e813bb Compare December 20, 2023 16:35
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 21, 2023
go-to-k
go-to-k approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 26, 2023
sumupitchayan
sumupitchayan previously approved these changes Dec 26, 2023
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sumupitchayan
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 26, 2023
@mergify mergify bot dismissed sumupitchayan’s stale review December 26, 2023 18:18

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5b6738f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 26, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9c0fecf into aws:main Dec 26, 2023
17 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 26, 2023
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@lpizzinidev @paulhcsun
fix(ecs-patterns): ApplicationMultipleTargetGroupsEc2Service ignore…
6e5e7d1 
…s load balancer name (aws#28394)

Fixes by adding the `loadBalancerName` property to the generated `ApplicationLoadBalancer`.

Closes aws#23535.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@go-to-k go-to-k go-to-k approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
4 participants
@lpizzinidev @sumupitchayan @aws-cdk-automation @go-to-k