-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-gateway-v2): Add method to generate flexible execute-api ARN #28400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
@badmintoncryer can you update the README with some info and an example of using this new feature? |
fb7ac3f
to
b8cf39b
Compare
@badmintoncryer the README is mostly the same as the alpha version because the API for the construct did not change when we stabilized the module. Just add to the README about the functionality you've added with a code example and explanation of the feature. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@sumupitchayan |
3bc4b65
to
ac50cec
Compare
@sumupitchayan I have reverted the README. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…aws#28400) This PR adds the arnForExecuteApi method, previously available only for REST API constructs, to both WebSocket and HTTP API constructs. Closes aws#23301 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds the arnForExecuteApi method, previously available only for REST API constructs, to both WebSocket and HTTP API constructs.
Closes #23301
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license