Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-gateway-v2): Add method to generate flexible execute-api ARN #28400

Merged
merged 7 commits into from
Dec 22, 2023

Conversation

badmintoncryer
Copy link
Contributor

This PR adds the arnForExecuteApi method, previously available only for REST API constructs, to both WebSocket and HTTP API constructs.

Closes #23301


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 17, 2023 15:05
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sumupitchayan
Copy link
Contributor

@badmintoncryer can you update the README with some info and an example of using this new feature?

@badmintoncryer badmintoncryer force-pushed the 23301-addArnForExecuteAPI branch from fb7ac3f to b8cf39b Compare December 21, 2023 13:21
@sumupitchayan
Copy link
Contributor

@sumupitchayan

The README for this construct is still the same as it was during the alpha version. Ideally, I think all of its content needs to be rewritten.

In this PR, should we refrain from doing that and just add to the README about the functions we've added??

@badmintoncryer the README is mostly the same as the alpha version because the API for the construct did not change when we stabilized the module. Just add to the README about the functionality you've added with a code example and explanation of the feature.

@badmintoncryer badmintoncryer marked this pull request as ready for review December 21, 2023 14:24
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 21, 2023 14:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer
Copy link
Contributor Author

@sumupitchayan
I'm very sorry. It seemed like the README from the alpha version was still there, but it appears I was mistaken. I have added the README for the updated feature.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 21, 2023
@badmintoncryer badmintoncryer force-pushed the 23301-addArnForExecuteAPI branch from 3bc4b65 to ac50cec Compare December 22, 2023 12:48
@badmintoncryer
Copy link
Contributor Author

@sumupitchayan I have reverted the README.

Copy link
Contributor

mergify bot commented Dec 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 22, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6276dfd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0932027 into aws:main Dec 22, 2023
12 checks passed
Copy link
Contributor

mergify bot commented Dec 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the 23301-addArnForExecuteAPI branch December 23, 2023 03:48
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
…aws#28400)

This PR adds the arnForExecuteApi method, previously available only for REST API constructs, to both WebSocket and HTTP API constructs. 

Closes aws#23301 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apigatewayv2: add arnForExecuteAPI method to HTTP API and WebSocket API construct
3 participants