feat(cloudwatch-actions): support alarm lambda action #28484

neilkuan · 2023-12-24T11:48:39Z

feat(cloudwatch-action): support alarm lambda action

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

neilkuan · 2024-01-01T05:29:15Z

Waiting #28542 merged.

…ub.com/neilkuan/aws-cdk into support-cloudwatch-alarm-lambda-action

neilkuan · 2024-01-03T09:08:17Z

hi @go-to-k cloud you help review this PR ?!
Thanks~~~

go-to-k

@neilkuan
Yes, I made some minor comments.

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts

...ws-cdk-testing/framework-integ/test/aws-cloudwatch-actions/test/integ.lambda-alarm-action.ts

…ub.com/neilkuan/aws-cdk into support-cloudwatch-alarm-lambda-action

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts

go-to-k

Good👍

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts

paulhcsun

Overall this looks good to me, could you just add a description to the example in the README please?

packages/aws-cdk-lib/aws-cloudwatch-actions/README.md

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts

Pull request has been modified.

paulhcsun

Great work @neilkuan, thanks for this contribution!

And thank you for reviewing @go-to-k!

aws-cdk-automation · 2024-01-11T18:57:36Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 7aec9fe
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-01-11T18:58:00Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

cwill-smg · 2024-01-15T09:47:32Z

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts

+   * @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_PutMetricAlarm.html
+   */
+  bind(_scope: Construct, _alarm: cloudwatch.IAlarm): cloudwatch.AlarmActionConfig {
+    this.lambdaFunction.addPermission('AlarmPermission', {


Why is the id not generated? Using static value AlarmPermission prohibits using the same lambda for multiple actions.

Something like this

const lambdaAction = () => new awsCloudWatchActions.LambdaAction(lambda); alarmConcurrentLambdasMaximumReached.addAlarmAction(lambdaAction()); alarmRdsCpuUtilizationMaximumReached.addAlarmAction(lambdaAction());

leads to following error:

throw new Error(`There is already a Construct with name '${childName}' in ${typeName}${name.length > 0 ? ' [' + name + ']' : ''}`); ^ Error: There is already a Construct with name 'AlarmPermission' in NodejsFunction [...]

I see. I have submitted a PR, so please wait a little longer.

#28712

Awesome, thanks for your very fast support!

Thanks! If you could upvote in the PR, the review may be prioritized.

feat: cloudwatch alarm lambda action

7429bca

github-actions bot added feature-request A feature should be added or improved. p2 labels Dec 24, 2023

aws-cdk-automation requested a review from a team December 24, 2023 11:48

github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Dec 24, 2023

aws-cdk-automation previously requested changes Dec 24, 2023

View reviewed changes

chore: add testing

07f3987

github-actions bot mentioned this pull request Jan 1, 2024

Monthly PR metrics report - Dec 2023 #28544

Closed

neilkuan added 2 commits January 1, 2024 04:43

chore: update code

a347097

chore: add integ testing

0fefaed

neilkuan added 4 commits January 1, 2024 13:37

feat: cloudwatch alarm lambda action

b895833

chore: add testing

6cbfe8b

chore: update code

3756913

chore: add integ testing

d2e6e06

neilkuan force-pushed the support-cloudwatch-alarm-lambda-action branch from 0fefaed to d2e6e06 Compare January 1, 2024 05:37

Merge branch 'support-cloudwatch-alarm-lambda-action' of https://gith…

3403cfb

…ub.com/neilkuan/aws-cdk into support-cloudwatch-alarm-lambda-action

neilkuan changed the title ~~feat(cloudwatch-action): support alarm lambda action~~ feat(cloudwatch-actions): support alarm lambda action Jan 2, 2024

github-actions bot added the effort/medium Medium work item – several days of effort label Jan 2, 2024

kaizencc and others added 3 commits January 2, 2024 20:55

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

e8b5869

chore: update readme

ad2939b

chore: update readme

b8c33eb

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 3, 2024

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

dfb285f

go-to-k suggested changes Jan 3, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 3, 2024

neilkuan and others added 2 commits January 4, 2024 08:34

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

83ff289

chore: update code from pr review

3a3e5b1

pahud added 2 commits January 4, 2024 03:18

update snapshots

d8bde8a

Merge branch 'support-cloudwatch-alarm-lambda-action' of https://gith…

e634b2f

…ub.com/neilkuan/aws-cdk into support-cloudwatch-alarm-lambda-action

neilkuan requested a review from go-to-k January 4, 2024 03:57

go-to-k suggested changes Jan 4, 2024

View reviewed changes

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts Outdated Show resolved Hide resolved

neilkuan added 2 commits January 4, 2024 04:22

chore: update testing and comment

d8aded1

chore: let testing happy

b20de81

neilkuan requested a review from go-to-k January 4, 2024 06:36

go-to-k approved these changes Jan 4, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 4, 2024

go-to-k reviewed Jan 4, 2024

View reviewed changes

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts Outdated Show resolved Hide resolved

neilkuan and others added 2 commits January 4, 2024 16:16

chore: typo

dc13eec

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

ce176dc

paulhcsun previously requested changes Jan 11, 2024

View reviewed changes

packages/aws-cdk-lib/aws-cloudwatch-actions/README.md Show resolved Hide resolved

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-cloudwatch-actions/lib/lambda.ts Outdated Show resolved Hide resolved

paulhcsun added 2 commits January 10, 2024 16:44

Small grammar change

36f0b15

Small grammar change

c7468ee

neilkuan and others added 2 commits January 11, 2024 09:32

chore: add description for lambda alias and version

d4c760f

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

fb79f07

neilkuan requested a review from paulhcsun January 11, 2024 02:00

neilkuan and others added 2 commits January 11, 2024 14:37

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

d876c52

Merge branch 'main' into support-cloudwatch-alarm-lambda-action

7aec9fe

paulhcsun approved these changes Jan 11, 2024

View reviewed changes

mergify bot merged commit b9f4923 into aws:main Jan 11, 2024
11 checks passed

cwill-smg reviewed Jan 15, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cloudwatch-actions): support alarm lambda action #28484

feat(cloudwatch-actions): support alarm lambda action #28484

neilkuan commented Dec 24, 2023

aws-cdk-automation left a comment

neilkuan commented Jan 1, 2024

neilkuan commented Jan 3, 2024

go-to-k left a comment

go-to-k left a comment

paulhcsun left a comment

paulhcsun left a comment •

edited

Loading

aws-cdk-automation commented Jan 11, 2024

mergify bot commented Jan 11, 2024

cwill-smg Jan 15, 2024

mcbain Jan 15, 2024

go-to-k Jan 15, 2024 •

edited

Loading

cwill-smg Jan 16, 2024

go-to-k Jan 16, 2024

feat(cloudwatch-actions): support alarm lambda action #28484

feat(cloudwatch-actions): support alarm lambda action #28484

Conversation

neilkuan commented Dec 24, 2023

aws-cdk-automation left a comment

Choose a reason for hiding this comment

neilkuan commented Jan 1, 2024

neilkuan commented Jan 3, 2024

go-to-k left a comment

Choose a reason for hiding this comment

go-to-k left a comment

Choose a reason for hiding this comment

paulhcsun left a comment

Choose a reason for hiding this comment

paulhcsun left a comment • edited Loading

Choose a reason for hiding this comment

aws-cdk-automation commented Jan 11, 2024

AWS CodeBuild CI Report

mergify bot commented Jan 11, 2024

cwill-smg Jan 15, 2024

Choose a reason for hiding this comment

mcbain Jan 15, 2024

Choose a reason for hiding this comment

go-to-k Jan 15, 2024 • edited Loading

Choose a reason for hiding this comment

cwill-smg Jan 16, 2024

Choose a reason for hiding this comment

go-to-k Jan 16, 2024

Choose a reason for hiding this comment

paulhcsun left a comment •

edited

Loading

go-to-k Jan 15, 2024 •

edited

Loading