feat(events-targets): launchType property for ECS task
#29069
Conversation
github-actions
bot
added
effort/medium
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
go-to-k
changed the title
launchType property for ECS task
go-to-k
changed the title
launchType property for ECS tasklaunchType property for ECS task
unit tests fix
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -389,6 +390,29 @@ rule.addTarget( | |||
| ); | |||
| ``` | |||
|
|
|||
| ### Launch type for ECS Task | |||
There was a problem hiding this comment.
In the next section "Assign public IP addresses to tasks", the word launch type appears, so I put it here.
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
### Issue # (if applicable) Closes #28990. ### Reason for this change There are cases where a task definition is created to be compatible with both EC2 and Fargate, and then we want to run the task in Fargate. ### Description of changes I created the `launchType` property. The `launchType` is overridden if the property is specified. ### Description of how you validated changes Both unit and integ tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Issue # (if applicable)
Closes #28990.
Reason for this change
There are cases where a task definition is created to be compatible with both EC2 and Fargate, and then we want to run the task in Fargate.
Description of changes
I created the
launchTypeproperty. ThelaunchTypeis overridden if the property is specified.Description of how you validated changes
Both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license