fix(opensearch): cannot disable cluster logging #29205
Conversation
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
sigJoe
changed the title
sigJoe
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Clarification Request: Please advise. I did my best before asking, but I don't understand what the PR checks are complaining about or how to fix it. Update: I figured it out. |
aws-cdk-automation
added
the
pr/reviewer-clarification-requested
sigJoe
force-pushed
the
opensearch-allow-disable-logging
branch
from
b14e432 to
fdccd5b
Compare
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Looks good 👍
There is only one file that should be removed from the PR imo.
Also, can you please update the title to describe the bug (not the solution).
tests.txt
Outdated
There was a problem hiding this comment.
Why is this file included? 🤔
There was a problem hiding this comment.
I based my test on what I thought were existing patterns, and this file contained a list of all the tests so I inserted mine as well
/shrug
I'll remove it now
aws-cdk-automation
added
pr/needs-maintainer-review
sigJoe
changed the title
tests.txt
Outdated
| @@ -1 +1 @@ | |||
| @aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket-auto-delete-objects.js | |||
| @aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket-auto-delete-objects.js | |||
There was a problem hiding this comment.
curious why GH is highlighting this change but they seem to be identical?
There was a problem hiding this comment.
It was missing a newline. Sorry about that. It's fixed now
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
### Issue # (if applicable) aws#29294 ### Reason for this change Currently cannot disable opensearch logging ### Description of changes If log parameters are explicitly set to false rather than undefined, it populates the logPublishingOptions with config to disable that logging ### Description of how you validated changes I added unit tests, although to be honest jest is giving me lots of trouble and I'm out of time for the day so I'll just create this pR and see what happens. Fingers crossed the PR test check is clean and I can pretend I know what I'm doing. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: GZ <yuanhaoz@amazon.com>
Issue # (if applicable)
#29294
Reason for this change
Currently cannot disable opensearch logging
Description of changes
If log parameters are explicitly set to false rather than undefined, it populates the logPublishingOptions with config to disable that logging
Description of how you validated changes
I added unit tests, although to be honest jest is giving me lots of trouble and I'm out of time for the day so I'll just create this pR and see what happens. Fingers crossed the PR test check is clean and I can pretend I know what I'm doing.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license