fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329

Tietew · 2024-03-01T05:34:11Z

Reason for this change

When I want to move a domain name from a distribution to another distribution,
I must create a distribution with a certificate associated but no domain names.

Description of changes

This PR removes the validation that domainNames must not be blank when a certificate is associated.

Description of how you validated changes

Updated a unit test to allow absent domainNames when a certificate is associated.

See AWS Documentation for details: Using custom URLs by adding alternate domain names (CNAMEs) > Moving an alternate domain name to a different distribution
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/CNAMEs.html#alternate-domain-names-move

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Tietew · 2024-03-01T05:42:00Z

Exemption Request

There are no integ tests for a distribution with a certificate.

mwebber · 2024-03-13T18:44:28Z

@Tietew We are keen to see this change completed - is there anything we can do? It looks like it's waiting on a reviewer.

msambol · 2024-03-20T03:54:03Z

@Tietew Could you attach a screenshot of this behavior? Given there are no integ tests with certificates.

aws-cdk-automation · 2024-03-23T00:08:20Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

…-domainname

aws-cdk-automation · 2024-03-31T00:10:07Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

paulhcsun

Hey @Tietew, apologies for not getting around to this. I've reopened the PR and added the do-not-close label to it.

We require that every fix be associated to an issue so could you also create an issue for this and link it in the PR description body? Also as @msambol mentioned would you be able to attach some screenshots of the behaviour please?

paulhcsun · 2024-04-04T22:31:52Z

packages/aws-cdk-lib/aws-cloudfront/README.md

@@ -79,6 +79,9 @@ be retrieved from `distribution.distributionDomainName`. CloudFront distribution
 default. If you want to use your own domain name, such as `www.example.com`, you must associate a certificate with your distribution that contains
 your domain name, and provide one (or more) domain names from the certificate for the distribution.

+When you want to move a domain name between distributions, you can associate a certificate and specify no domain names.


Suggested change

When you want to move a domain name between distributions, you can associate a certificate and specify no domain names.

When you want to move a domain name between distributions, you can associate a certificate without specifying any domain names.

paulhcsun · 2024-04-04T22:47:07Z

packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts

@@ -129,7 +129,7 @@ export interface DistributionProps {
   *
   * If you want to use your own domain name, such as www.example.com, instead of the cloudfront.net domain name,
   * you can add an alternate domain name to your distribution. If you attach a certificate to the distribution,
-   * you must add (at least one of) the domain names of the certificate to this list.


Since this is no longer something required, could you also add a sentence at the end explaining the case where we don't need to provide a domain name?

aws-cdk-automation · 2024-04-04T22:52:47Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 5dba751
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2024-04-26T00:08:33Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation · 2024-05-03T00:09:40Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

…name between distributions (#31001) ### Issue # (if applicable) Closes #29960. ### Reason for this change When I want to move a domain name from a distribution to another distribution, I must create a distribution with a certificate associated but no domain names. ### Description of changes Re-submit of previous #29329. Removed the validation that `domainNames` must not be blank when a certificate is associated. ### Description of how you validated changes Updated a unit test to allow absent domainNames when a certificate is associated. See AWS Documentation for details: Using custom URLs by adding alternate domain names (CNAMEs) > Moving an alternate domain name to a different distribution https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/CNAMEs.html#alternate-domain-names-move ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

allow blank domainNames

54fedef

github-actions bot added the p2 label Mar 1, 2024

aws-cdk-automation requested a review from a team March 1, 2024 05:34

github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Mar 1, 2024

aws-cdk-automation previously requested changes Mar 1, 2024

View reviewed changes

aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 1, 2024

Merge remote-tracking branch 'origin/main' into cloudfront-allow-move…

a444971

…-domainname

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Mar 31, 2024

aws-cdk-automation closed this Mar 31, 2024

github-actions bot mentioned this pull request Apr 1, 2024

Monthly PR metrics report #29668

Closed

paulhcsun reopened this Apr 4, 2024

paulhcsun added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 4, 2024

Merge branch 'main' into cloudfront-allow-move-domainname

5dba751

paulhcsun added pr-linter/do-not-close The PR linter will not close this PR while this label is present and removed closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. labels Apr 4, 2024

paulhcsun changed the title ~~fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions~~ fix(cloudfront): requirement of domainNames prevents moving a domain name between distribution Apr 4, 2024

paulhcsun changed the title ~~fix(cloudfront): requirement of domainNames prevents moving a domain name between distribution~~ fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions Apr 4, 2024

paulhcsun requested changes Apr 4, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 4, 2024

TheRealAmazonKendra removed pr-linter/do-not-close The PR linter will not close this PR while this label is present pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Apr 17, 2024

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 3, 2024

aws-cdk-automation closed this May 3, 2024

Tietew mentioned this pull request Aug 1, 2024

fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #31001

Merged

1 task

This was referenced Sep 15, 2024

[Snyk] Upgrade aws-cdk-lib from 2.151.0 to 2.154.1 mannjaro/serverless-bedrock-proxy#2

Merged

[Snyk] Upgrade aws-cdk-lib from 2.154.1 to 2.155.0 mannjaro/serverless-bedrock-proxy#4

Open

This was referenced Oct 6, 2024

[Snyk] Upgrade @aws-cdk/cloudformation-diff from 2.99.1 to 2.158.0 NOUIY/aws-solutions-constructs#133

Open

[Snyk] Upgrade aws-cdk from 2.99.1 to 2.158.0 NOUIY/aws-solutions-constructs#134

Open

ajobayer mentioned this pull request Oct 18, 2024

[Snyk] Upgrade aws-cdk-lib from 2.101.0 to 2.160.0 ajobayer/aws-secure-environment-accelerator#4

Open

WontonSam mentioned this pull request Oct 25, 2024

[Snyk] Upgrade aws-cdk from 1.128.0 to 2.160.0 WontonSam/apollo-federation-subgraph-compatibility#620

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329

fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329

Tietew commented Mar 1, 2024

aws-cdk-automation left a comment

Tietew commented Mar 1, 2024

mwebber commented Mar 13, 2024

msambol commented Mar 20, 2024

aws-cdk-automation commented Mar 23, 2024

aws-cdk-automation commented Mar 31, 2024

paulhcsun left a comment

paulhcsun Apr 4, 2024

paulhcsun Apr 4, 2024

aws-cdk-automation commented Apr 4, 2024

aws-cdk-automation commented Apr 26, 2024

aws-cdk-automation commented May 3, 2024

	When you want to move a domain name between distributions, you can associate a certificate and specify no domain names.
	When you want to move a domain name between distributions, you can associate a certificate without specifying any domain names.

fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329

fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329

Conversation

Tietew commented Mar 1, 2024

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Tietew commented Mar 1, 2024

mwebber commented Mar 13, 2024

msambol commented Mar 20, 2024

aws-cdk-automation commented Mar 23, 2024

aws-cdk-automation commented Mar 31, 2024

paulhcsun left a comment

Choose a reason for hiding this comment

paulhcsun Apr 4, 2024

Choose a reason for hiding this comment

paulhcsun Apr 4, 2024

Choose a reason for hiding this comment

aws-cdk-automation commented Apr 4, 2024

AWS CodeBuild CI Report

aws-cdk-automation commented Apr 26, 2024

aws-cdk-automation commented May 3, 2024