feat(elasticloadbalancingv2): denyAllIgwTraffic and clientRoutingPolicy for NLB
#29521
Conversation
github-actions
bot
added
feature-request
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
badmintoncryer
force-pushed
the
nlbAttributes
branch
from
210aa0a to
813e14f
Compare
badmintoncryer
changed the title
denyAlligwTraffic and clientRoutingPolicy for NLB
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
badmintoncryer
changed the title
denyAlligwTraffic and clientRoutingPolicy for NLBdenyAllIgwTraffic and clientRoutingPolicy for NLB
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -119,6 +119,7 @@ export class ApplicationLoadBalancer extends BaseLoadBalancer implements IApplic | |||
| if (props.idleTimeout !== undefined) { this.setAttribute('idle_timeout.timeout_seconds', props.idleTimeout.toSeconds().toString()); } | |||
| if (props.dropInvalidHeaderFields) {this.setAttribute('routing.http.drop_invalid_header_fields.enabled', 'true'); } | |||
| if (props.desyncMitigationMode !== undefined) {this.setAttribute('routing.http.desync_mitigation_mode', props.desyncMitigationMode); } | |||
| if (props.deletionProtection !== undefined) { this.setAttribute('deletion_protection.enabled', props.deletionProtection.toString()); } | |||
There was a problem hiding this comment.
This seems redundant 🤔
There was a problem hiding this comment.
Oops..
I have removed this line. Thanks!
aws-cdk-automation
added
pr/needs-maintainer-review
badmintoncryer
force-pushed
the
nlbAttributes
branch
from
0c93175 to
bb1b1f2
Compare
| @@ -193,7 +193,7 @@ If you do not provide any options for this method, it redirects HTTP port 80 to | |||
| By default all ingress traffic will be allowed on the source port. If you want to be more selective with your | |||
| ingress rules then set `open: false` and use the listener's `connections` object to selectively grant access to the listener. | |||
|
|
|||
| ### Load Balancer attributes | |||
| ### Application Load Balancer attributes | |||
There was a problem hiding this comment.
Nice, thanks for updating the name and make it clear to separate ALB vs NLB.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@GavinZZ Thank you for your review! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…olicy` for NLB (aws#29521) ### Issue # (if applicable) Closes aws#29520. ### Reason for this change NLB supports `ipv6.deny_all_igw_traffic` and `dns_record.client_routing_policy` but these are not configurable from AWS CDK. ### Description of changes - add `zonalAffinity` props to `NetworkLoadBalancerProps` - add `denyAllIgwTraffic` props to `BaseLoadBalancerProps` - `ipv6.deny_all_igw_traffic` is also supported by ALB ### Description of how you validated changes I've added both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: GZ <yuanhaoz@amazon.com>
Issue # (if applicable)
Closes #29520.
Reason for this change
NLB supports
ipv6.deny_all_igw_trafficanddns_record.client_routing_policybut these are not configurable from AWS CDK.Description of changes
zonalAffinityprops toNetworkLoadBalancerPropsdenyAllIgwTrafficprops toBaseLoadBalancerPropsipv6.deny_all_igw_trafficis also supported by ALBDescription of how you validated changes
I've added both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license