fix(sns): contentBasedDeduplication is always false for imported topic

[msambol]

Closes #29532.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[msambol]

Exemption request: I don't believe an integration test is needed here.

[msambol]

@lpizzinidev This should be better now..

[lpizzinidev]

Thanks for the changes 👍
Left some comments for further adjustments.
Also, can you please add integration test coverage for the Topic.fromTopicArn and Topic.fromTopicAttributes methods?

[msambol]

@lpizzinidev This should be better now.

[lpizzinidev]

Thanks 👍
Looks good to me, just a final adjustment on the integration tests is needed in my opinion

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[shikha372]

Thank you @msambol for your contribution, as per my understanding content based deduplication is available only for the FIFO queue, so if we are allowing users to set this value for imported topics, they might mistakenly set it for standard queue and face issue during deployment. Could we add validation that this is being set from attributes only in case in fifo queue.

[msambol]

Thank you @msambol for your contribution, as per my understanding content based deduplication is available only for the FIFO queue, so if we are allowing users to set this value for imported topics, they might mistakenly set it for standard queue and face issue during deployment. Could we add validation that this is being set from attributes only in case in fifo queue.

Great catch! Updated.

[shikha372]

LGTM .. Thank you @msambol for contributing and @lpizzinidev for review

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ac70ae9
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).