Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunction): add enableExecuteCommand to sfn ECSRunTask #29638

Merged
merged 4 commits into from
Apr 1, 2024
Merged

feat(stepfunction): add enableExecuteCommand to sfn ECSRunTask #29638

merged 4 commits into from
Apr 1, 2024

Conversation

matthiasgubler
Copy link
Contributor

Issue #29637

Closes #29637

Reason for this change

Allow setting the enableExecuteCommand for ECSRunTask in sfn

Description of changes

Add the enableExecuteCommand property to the EcsRunTaskProps, to start the task from step functions with execution command enabled.

Description of how you validated changes

Unit-test added. Existing ones passed.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 28, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 28, 2024 17:16
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Mar 28, 2024
@matthiasgubler matthiasgubler changed the title feat(): add enableExecuteCommand to sfn ECSRunTask feat(aws-stepfunction-tasks): add enableExecuteCommand to sfn ECSRunTask Mar 28, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@matthiasgubler matthiasgubler changed the title feat(aws-stepfunction-tasks): add enableExecuteCommand to sfn ECSRunTask feat(stepfunction): add enableExecuteCommand to sfn ECSRunTask Mar 28, 2024
@matthiasgubler matthiasgubler force-pushed the 29637-enableexecutecommand-ecs-sfn branch from 01ff241 to c17fb1c Compare March 28, 2024 18:17
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 28, 2024 18:18

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 28, 2024
aaythapa
aaythapa reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change! Most of the diff seem to come from format, not sure if that was intentional. If you could remove those as the format doesn't match the rest of the repo.

Also would prefer a bit more documentation or links to some (maybe in the README).

packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-ecs-task-base.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-task.ts Outdated Show resolved Hide resolved
@matthiasgubler matthiasgubler force-pushed the 29637-enableexecutecommand-ecs-sfn branch from c17fb1c to ccebd21 Compare March 28, 2024 21:16
@matthiasgubler matthiasgubler requested a review from aaythapa March 28, 2024 21:17
@matthiasgubler matthiasgubler force-pushed the 29637-enableexecutecommand-ecs-sfn branch from ccebd21 to 2f4ef2b Compare March 28, 2024 21:50
@matthiasgubler matthiasgubler force-pushed the 29637-enableexecutecommand-ecs-sfn branch from 2f4ef2b to 15af2b3 Compare March 29, 2024 00:10
@matthiasgubler matthiasgubler requested a review from msambol March 31, 2024 14:21
msambol
msambol approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 31, 2024
This was referenced Apr 1, 2024
Closed
Closed
aaythapa
aaythapa reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

aaythapa
aaythapa previously approved these changes Apr 1, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed aaythapa’s stale review April 1, 2024 21:36

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a691726
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d5b8594 into aws:main Apr 1, 2024
12 checks passed
@matthiasgubler matthiasgubler deleted the 29637-enableexecutecommand-ecs-sfn branch April 1, 2024 22:08
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaythapa aaythapa aaythapa approved these changes

@msambol msambol msambol approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-stepfunction-tasks): Support enableExecuteCommand in EcsRunTask
4 participants
@matthiasgubler @aws-cdk-automation @msambol @aaythapa