fix(integ-tests): httpApiCall.expect
with resolved URL
#29705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29700
I've also opened #29701 to catch similar issues at synth time in the future
Reason for this change
When running
httpApiCall('url').expect
, theAssertionResults
output logical ID would be overridden with an invalid name, containing the URL slashes.This issue was not noticed earlier because, as far as I can tell, assertions were only made with
Token
/Ref
URLs, e.g.apigw.DomainName
Description of changes
AssertionResults
output logical IDExpectedResult
, I noticed it was slightly lacking while creating the integration testDescription of how you validated changes
I've added unit and integration tests. The integration tests include both tests with API Gateway, to cover unresolved URLs, and to https://httpbin.org/ to test this fix
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license