Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(settings): ability to specific developer's local settings via cdk.local.json #29821

Open
1 of 2 tasks
kornicameister opened this issue Apr 12, 2024 · 2 comments
Open
1 of 2 tasks
Labels
@aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@kornicameister
Copy link
Contributor

kornicameister commented Apr 12, 2024

Describe the feature

I'd want my developers to be able to specify certain context settings via untracked cdk.local.json file.
Something similar to .env.local that is untracked and presents an opportunity for developers to configure their stacks without stepping on each other toes.

I am aware that there is ~/cdk.json being a global configuration developer can apply but this particular's setting issue is its global impact on anything that's developed/deployed whereas I am looking for more isolated approach that allows to define settings per project.

Use Case

Point here is not to bloat either cdk.json or cdk.context.json files that are tracked, or in my case can be tracked when it comes to cdk.context.json. Reason for not tracking cdk.context.json lies in a fact that my organization develops various services as L3 components (packaged as NPM packages) that are combined with preview. Preview actually uses the L3 component to deploy isolated micro service. Given that all developers have their accounts it would be quite problematic to manage cdk.context.json if it were submitted to repository.

Later all components are integrated in bigger application which itself can benefit from cdk.local.json allowing developers to test integration.

Proposed Solution

Modify settings.ts by adding export const PROJECT_LOCAL_CONFIG = 'cdk.local.json'; and adjusting code to load it up similarly to USER_DEFAULTS.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.137.0

Environment details (OS name and version, etc.)

MacOS Sierra

@kornicameister kornicameister added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 12, 2024
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 15, 2024
@khushail khushail removed their assignment Apr 16, 2024
@kornicameister
Copy link
Contributor Author

@khushail care to verify if PR is in the right direction and if it even makes sense?

@khushail khushail added @aws-cdk/core Related to core CDK functionality and removed @aws-cdk/core Related to core CDK functionality labels Apr 22, 2024
@khushail
Copy link
Contributor

@kornicameister ,Yes, we have requested more input from the maintainers but feel free to add any description about your suggested solution if you like.

@khushail khushail removed the @aws-cdk/core Related to core CDK functionality label Apr 22, 2024
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@khushail khushail added @aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants