Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKv3-06: Update cdk-assets #29841

Closed
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 1 comment
Closed
Tracked by #29694

SDKv3-06: Update cdk-assets #29841

TheRealAmazonKendra opened this issue Apr 15, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@TheRealAmazonKendra
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

Update cdk-assets to use sdkv3 and update the locations in aws-cdk required so that the types used are the same.

Known uses:

  • lib/aws.ts: this generates a default client that is used extensively elsewhere in this package and in aws-cdk
  • lib/private/handlers/container-image.ts: creates an ECR client that is used in a few locations
  • test/mock-aws.ts

Acceptance Criteria

  1. sdkv2 is completely removed from the cdk-assets package
  2. Updates are made where needed in aws-cdk to not cause type confilcts
  3. All tests (unit and integ) pass after the change has been made.
@TheRealAmazonKendra TheRealAmazonKendra self-assigned this Apr 15, 2024
@TheRealAmazonKendra TheRealAmazonKendra mentioned this issue Apr 15, 2024
Open
10 tasks
@TheRealAmazonKendra TheRealAmazonKendra added the in-progress This issue is being actively worked on. label Apr 15, 2024
@khushail khushail mentioned this issue Apr 15, 2024
Open
This was referenced Apr 22, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue May 1, 2024
Closed
@ashishdhingra ashishdhingra added p2 feature-request A feature should be added or improved. labels Jul 31, 2024
@rix0rrr rix0rrr closed this as completed Nov 12, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rix0rrr @TheRealAmazonKendra @ashishdhingra