-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(elasticloadbalancingv2): crossZoneEnabled does not support false for ALB #29907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #29866
Reason for this change
crossZoneEnabled
is not well handled when it'sfalse
with ALB. Because:false
, it will not pass down to the L1 and won't throw any error as ALB does not support being disabled. It just silently ignore it.false
for NLB, the L1 attribute will beundefined
, which is having the same result but it should be explicitly set asfalse
in L1.This PR covers the following cases:
crossZoneEnabled
istrue
,load_balancing.cross_zone.enabled
should betrue
.crossZoneEnabled
isfalse
,load_balancing.cross_zone.enabled
should befalse
, rather thanundefined
.crossZoneEnabled
isfalse
with ALB, cdk throws an error because ALB does not support disabling it per doc description.true
orfalse
.undefined
for ALB or NLB.crossZoneEnabled
prop.Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license