Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): documentation fix for retryOnServiceExceptions #30077

Merged
merged 2 commits into from
May 13, 2024

Conversation

schmiddy
Copy link
Contributor

@schmiddy schmiddy commented May 6, 2024

Issue # (if applicable)

N/A

Reason for this change

Doc correction for retryOnServiceExceptions.

The code here was updated in #26474 , so that the error Lambda.ClientExecutionTimeoutException is handled automatically by retryOnServiceExceptions. However, the documentation comment was not updated to reflect this change.

Description of changes

Explain that Lambda.ClientExecutionTimeoutException is also handled automatically as part of retryOnServiceExceptions

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

  aws#26474

to include retry handling for `Lambda.ClientExecutionTimeoutException`, as well.
@github-actions github-actions bot added the p2 label May 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 6, 2024 16:10
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 6, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@schmiddy schmiddy changed the title Doc correction for retryOnServiceExceptions fix(stepfunctions-tasks) documentation fix for retryOnServiceExceptions May 6, 2024
@schmiddy schmiddy changed the title fix(stepfunctions-tasks) documentation fix for retryOnServiceExceptions fix(stepfunctions-tasks): documentation fix for retryOnServiceExceptions May 6, 2024
@schmiddy
Copy link
Contributor Author

schmiddy commented May 6, 2024

Exemption Request - I don't believe there is a test file or integration test that should be changed here

@gracelu0 gracelu0 added docs/inline Related to inline documentation of the API Reference pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 6, 2024 20:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 6, 2024
gracelu0
gracelu0 previously approved these changes May 13, 2024
Copy link
Contributor

@gracelu0 gracelu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

mergify bot commented May 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 13, 2024
Copy link
Contributor

mergify bot commented May 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@gracelu0
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 13, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed gracelu0’s stale review May 13, 2024 22:48

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7d85da8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented May 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK docs/inline Related to inline documentation of the API Reference p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants