Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): dualstack ALB #30089

Merged
merged 24 commits into from
Aug 30, 2024
Merged

feat(ecs-patterns): dualstack ALB #30089

merged 24 commits into from
Aug 30, 2024

Conversation

badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #29039.

Reason for this change

Both ApplicationLoadBalancedFargateService and ApplicationLoadBalancedEc2Service don't support specifying dualstack ALB.

Description of changes

Added ipAddressType to ApplicationLoadBalancedServiceBaseProps.

Description of how you validated changes

Added both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels May 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 7, 2024 12:02
@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels May 7, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation aws-cdk-automation dismissed their stale review May 19, 2024 03:17

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review May 19, 2024 03:20
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 19, 2024
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
@jmnarloch
Copy link

I would be interested in this change, is there anything I could help with?

@badmintoncryer
Copy link
Contributor Author

@jmnarloch Thanks for your comments. This PR waits for community review and I think it will take some weeks or months. Please wait a moment!

@teankie
Copy link

teankie commented Jul 1, 2024

When will this PR be approved and merged?

@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented Jul 1, 2024 •
edited
Loading

@teankie It depends on the community reviewer and maintainer. Please 👍 to the issue to increase the priority.

@jmnarloch jmnarloch mentioned this pull request Jul 1, 2024
Closed
2 tasks
@pahud
Copy link
Contributor

pahud commented Jul 30, 2024

Hi

This PR has been pending for community review for a while. Please consider posting it on the #contributing channel in cdk.dev. Community members will be on the lookout there as well for possible reviews.

Check How to get your P2 PR community reviewed for more details.

tmokmss
tmokmss approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@tmokmss tmokmss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks just to add a property in the same way as #30069. There seem to be two more constructs to be updated (ApplicationMultipleTargetGroupsServiceBase and NetworkMultipleTargetGroupsServiceBase).

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 4, 2024
@badmintoncryer
Copy link
Contributor Author

@tmokmss Thank you for your review. I'll try to create PR for those constructs later😉

@badmintoncryer
Copy link
Contributor Author

@pahud
Hi

Thanks to my post on cdk.dev, this PR successfully passed the community review.
I would appreciate it if someone could conduct a maintainer review.

Thank you in advance.

GavinZZ
GavinZZ reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a slight doc update would make it perfect

packages/aws-cdk-lib/aws-ecs-patterns/README.md Show resolved Hide resolved
GavinZZ
GavinZZ approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate it!

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 30, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 737cf8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 98ea3db into aws:main Aug 30, 2024
12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
@badmintoncryer badmintoncryer deleted the 29039-dualstackAlb branch August 30, 2024 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@tmokmss tmokmss tmokmss approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApplicationLoadBalancedFargateService : Add Support for IPv6 on LB's
7 participants
@badmintoncryer @aws-cdk-automation @jmnarloch @teankie @pahud @tmokmss @GavinZZ