Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): add feature flag and remove ecs default deployment alarm settings #30217

Merged
merged 19 commits into from
May 15, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented May 15, 2024

Issue # (if applicable)

Internal ticket tracking V1142791950

Reason for this change

Originally in this PR #25840, we added default deployment alarm settings to fix an issue where adding deployment alarms, deploying your CFN stack, then removing the deployment alarms from the CFN template, and deploying again WILL NOT remove the deployment alarms from the service.

ECS now already supports default deployment alarm settings. We will remove the default setting of deploymentAlarms. Reason for removing this default behaviour is for region build where the deployment alarm service may not be available in new regions but is set by default by CDK.

Description of changes

Remove default deployment alarm.

Description of how you validated changes

All new tests and integration tests pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 15, 2024 18:07
@github-actions github-actions bot added the p2 label May 15, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 15, 2024
@GavinZZ GavinZZ added p1 and removed p2 labels May 15, 2024
@GavinZZ GavinZZ marked this pull request as ready for review May 15, 2024 19:46
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 15, 2024
@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented May 15, 2024

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented May 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 15, 2024
@GavinZZ GavinZZ added the pr/do-not-merge This PR should not be merged at this time. label May 15, 2024
@GavinZZ GavinZZ removed the pr/do-not-merge This PR should not be merged at this time. label May 15, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f403e68
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented May 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1e94267 into main May 15, 2024
13 checks passed
@mergify mergify bot deleted the yuanhaoz/fix_ecs_deployment_alarms_fix branch May 15, 2024 21:46
atanaspam pushed a commit to atanaspam/aws-cdk that referenced this pull request Jun 3, 2024
…ttings (aws#30217)

### Issue # (if applicable)

Internal ticket tracking V1142791950

### Reason for this change

Originally in this PR aws#25840, we added default deployment alarm settings to fix an issue where adding deployment alarms, deploying your CFN stack, then removing the deployment alarms from the CFN template, and deploying again WILL NOT remove the deployment alarms from the service.

ECS now already supports default deployment alarm settings. We will remove the default setting of deploymentAlarms. Reason for removing this default behaviour is for region build where the deployment alarm service may not be available in new regions but is set by default by CDK.

### Description of changes

Remove default deployment alarm.

### Description of how you validated changes

All new tests and integration tests pass.

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants