Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appsync): add maxBatchSize property to the AppSyncFunction Construct #30266

Merged
merged 12 commits into from
Jun 13, 2024
Merged

feat(appsync): add maxBatchSize property to the AppSyncFunction Construct #30266

merged 12 commits into from
Jun 13, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented May 18, 2024

Issue # (if applicable)

N/A

Reason for this change

Missing property in the Construct.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-functionconfiguration.html#cfn-appsync-functionconfiguration-maxbatchsize

Description of changes

Add maxBatchSize property to the AppSyncFunction Construct

Description of how you validated changes

Add unit tests and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 18, 2024 09:31
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels May 18, 2024
@mazyu36 mazyu36 marked this pull request as ready for review May 18, 2024 11:03
@github-actions github-actions bot mentioned this pull request May 20, 2024
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 23, 2024
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Closed
lpizzinidev
lpizzinidev suggested changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Left comments for minor documentation adjustments

packages/aws-cdk-lib/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/test/appsync-function.test.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 8, 2024
mazyu36 and others added 6 commits June 9, 2024 01:48
@mazyu36 @lpizzinidev
Update packages/aws-cdk-lib/aws-appsync/README.md
bc652df 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@mazyu36 @lpizzinidev
Update packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts
faccca3 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@mazyu36 @lpizzinidev
Update packages/aws-cdk-lib/aws-appsync/test/appsync-function.test.ts
e14f87e 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@mazyu36 @lpizzinidev
Update packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts
a949deb 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@mazyu36 @lpizzinidev
Update packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts
d7a71cf 
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@mazyu36
chore: spacing
c21530b
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 8, 2024

@lpizzinidev
Thank you always for your reviews!
I have addressed your comments.

lpizzinidev
lpizzinidev approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 9, 2024
aaythapa
aaythapa reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clarifying questions

...s-cdk-testing/framework-integ/test/aws-appsync/test/integ.appsync-function-max-batch-size.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-appsync/lib/appsync-function.ts Show resolved Hide resolved
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 11, 2024

@aaythapa
Thank you for the review.
I’ve addressed all your comments.

aaythapa
aaythapa approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 11, 2024

update

✅ Branch has been successfully updated

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 12, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 12, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a2124f3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1dc142 into aws:main Jun 13, 2024
9 checks passed
@mazyu36 mazyu36 deleted the appsync-function-maxbatchsize branch June 18, 2024 14:37
mazyu36 added a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
@mazyu36
feat(appsync): add maxBatchSize property to the AppSyncFunction C…
1971140 
…onstruct (aws#30266)

### Issue # (if applicable)

N/A

### Reason for this change
Missing property in the Construct.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-functionconfiguration.html#cfn-appsync-functionconfiguration-maxbatchsize



### Description of changes
Add `maxBatchSize` property to the `AppSyncFunction` Construct




### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jul 5, 2024
Open
Open
This was referenced Jul 16, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request Jul 23, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaythapa aaythapa aaythapa approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

Assignees
No one assigned
Labels
p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazyu36 @aws-cdk-automation @lpizzinidev @aaythapa