feat(cognito): add defaultRedirectUri to UserPoolClient #30481

mazyu36 · 2024-06-07T13:19:17Z

Issue # (if applicable)

N/A

Reason for this change

The defaulrRedirectUri property missing in the current UserPoolClient class,

The DefaultRedirectURI setting is essential when using Amazon Cognito Hosted UI because it specifies the primary destination where users will be redirected after successful authentication, ensuring a seamless and secure OAuth 2.0 or OpenID Connect flow.

Description of changes

Add missing property.

Description of how you validated changes

Add unit tests and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

lpizzinidev

Thanks 👍 Some minor TODOs

packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts

packages/aws-cdk-lib/aws-cognito/README.md

packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

mazyu36 · 2024-06-08T17:53:02Z

@lpizzinidev
Thank you. I have incorporated your suggestions and made modifications.
The error message has been modified to display only the regular expression pattern.

lpizzinidev

Thanks 👍

paulhcsun

Hi @mazyu36, thanks for the contribution! The code changes look good to me for the most part, I've just left a couple of clarifying questions.

packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts

paulhcsun · 2024-06-19T22:39:40Z

packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts

+        throw new Error('defaultRedirectUri must be included in callbackUrls.');
+      }
+
+      const defaultRedirectUriPattern = /^(?=.{1,1024}$)[\p{L}\p{M}\p{S}\p{N}\p{P}]+$/u;


Where is this pattern obtained from and what is it matching against?

Obtained from CFn document.

Pattern: [\p{L}\p{M}\p{S}\p{N}\p{P}]+

Minimum: 1

Maximum: 1024

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpoolclient.html#cfn-cognito-userpoolclient-defaultredirecturi

In my understanding, Most strings will match the pattern, but strings containing only whitespace characters or only special characters/symbols will not match.

Thanks for clarifying! Should we also add some validation on the length here?

Edit: Nevermind, I see that this already checks the length.

paulhcsun

Hi @mazyu36, thanks for the contribution! The code changes look good to me for the most part, I've just left a couple of clarifying questions.

mazyu36 · 2024-06-20T00:48:14Z

@paulhcsun
Thank you for the review!
I've replied to all your comments.

paulhcsun

Looks good, nice work @mazyu36!

And thanks for the review @lpizzinidev!

paulhcsun · 2024-06-20T22:46:54Z

@Mergifyio update

mergify · 2024-06-20T22:47:26Z

update

✅ Branch has been successfully updated

mergify · 2024-06-20T22:47:27Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mazyu36 · 2024-06-21T00:04:36Z

@Mergifyio update

mergify · 2024-06-21T00:04:47Z

update

✅ Branch has been successfully updated

aws-cdk-automation · 2024-06-21T00:34:54Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 29398d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-06-21T00:35:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

### Issue # (if applicable) N/A ### Reason for this change The `defaulrRedirectUri` property missing in the current `UserPoolClient` class, The DefaultRedirectURI setting is essential when using Amazon Cognito Hosted UI because it specifies the primary destination where users will be redirected after successful authentication, ensuring a seamless and secure OAuth 2.0 or OpenID Connect flow. ### Description of changes Add missing property. ### Description of how you validated changes Add unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2024-07-25T20:48:20Z

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

feat: add defaultRediretUri to UserPoolClient

b8c14b0

aws-cdk-automation requested a review from a team June 7, 2024 13:19

github-actions bot added p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jun 7, 2024

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 7, 2024

lpizzinidev suggested changes Jun 8, 2024

View reviewed changes

packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-cognito/README.md Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts Outdated Show resolved Hide resolved

mazyu36 and others added 4 commits June 9, 2024 01:54

Update packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts

5000fc1

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-cognito/README.md

55028f4

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

Update packages/aws-cdk-lib/aws-cognito/lib/user-pool-client.ts

5327c07

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>

fix: import error and unit tests

5e34546

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 8, 2024

fix: revert FEATURE_FLAG.md

6e7ab47

lpizzinidev approved these changes Jun 9, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 9, 2024

github-actions bot mentioned this pull request Jun 10, 2024

Weekly PR metrics report #30506

Closed

paulhcsun changed the title ~~feat(cognito): add defaultRediretUri to UserPoolClient~~ feat(cognito): add defaultRedirectUri to UserPoolClient Jun 19, 2024

paulhcsun reviewed Jun 20, 2024

View reviewed changes

mazyu36 requested a review from paulhcsun June 20, 2024 00:49

paulhcsun approved these changes Jun 20, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 20, 2024

Merge branch 'main' into userpool-client-default-redirect-uri

5ca0a7e

Merge branch 'main' into userpool-client-default-redirect-uri

29398d0

mergify bot merged commit f2c5f68 into aws:main Jun 21, 2024
10 checks passed

mazyu36 deleted the userpool-client-default-redirect-uri branch June 21, 2024 03:22

github-actions bot mentioned this pull request Jul 1, 2024

Monthly PR metrics report #30715

Closed

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cognito): add defaultRedirectUri to UserPoolClient #30481

feat(cognito): add defaultRedirectUri to UserPoolClient #30481

mazyu36 commented Jun 7, 2024

lpizzinidev left a comment

mazyu36 commented Jun 8, 2024

lpizzinidev left a comment

paulhcsun left a comment

paulhcsun Jun 19, 2024

mazyu36 Jun 20, 2024 •

edited

Loading

paulhcsun Jun 20, 2024 •

edited

Loading

paulhcsun left a comment

mazyu36 commented Jun 20, 2024

paulhcsun left a comment

paulhcsun commented Jun 20, 2024

mergify bot commented Jun 20, 2024

mergify bot commented Jun 20, 2024

mazyu36 commented Jun 21, 2024

mergify bot commented Jun 21, 2024

aws-cdk-automation commented Jun 21, 2024

mergify bot commented Jun 21, 2024

aws-cdk-automation commented Jul 25, 2024

feat(cognito): add defaultRedirectUri to UserPoolClient #30481

feat(cognito): add defaultRedirectUri to UserPoolClient #30481

Conversation

mazyu36 commented Jun 7, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

lpizzinidev left a comment

Choose a reason for hiding this comment

mazyu36 commented Jun 8, 2024

lpizzinidev left a comment

Choose a reason for hiding this comment

paulhcsun left a comment

Choose a reason for hiding this comment

paulhcsun Jun 19, 2024

Choose a reason for hiding this comment

mazyu36 Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

paulhcsun Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

paulhcsun left a comment

Choose a reason for hiding this comment

mazyu36 commented Jun 20, 2024

paulhcsun left a comment

Choose a reason for hiding this comment

paulhcsun commented Jun 20, 2024

mergify bot commented Jun 20, 2024

✅ Branch has been successfully updated

mergify bot commented Jun 20, 2024

mazyu36 commented Jun 21, 2024

mergify bot commented Jun 21, 2024

✅ Branch has been successfully updated

aws-cdk-automation commented Jun 21, 2024

AWS CodeBuild CI Report

mergify bot commented Jun 21, 2024

aws-cdk-automation commented Jul 25, 2024

mazyu36 Jun 20, 2024 •

edited

Loading

paulhcsun Jun 20, 2024 •

edited

Loading