Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-amplify-alpha: Add support for custom ACM cert #30594

Labels
@aws-cdk/aws-amplify Related to AWS Amplify effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@thedevopsguyblog
Copy link

Describe the feature

Hello,

In the UI their is an option to specify a custom SSL cert that is provisioned via ACM.

Screenshot 2024-06-20 at 9 59 48 am

Using the aws-amplify-alpha construct it would be handy if i could specify a SSL cert I would like to use.

Use Case

I know Specifically in the case when i want to provision my own cert for a custom domain name in cognito and use the same cert for my frontend.

Proposed Solution

  1. Provision the ACM managed cert in a separate stack
      new cdk.aws_certificatemanager.Certificate(this, 'Certificate', {
        domainName: props!.envVars.FQDN,
        validation: cdk.aws_certificatemanager.CertificateValidation.fromDns(importedHostedZone),
        subjectAlternativeNames:[
            `*.${props!.envVars.FQDN}`,
            `*.api.${props!.envVars.FQDN}`,
            `*.auth.${props!.envVars.FQDN}`,
        ]
      });
    }
  1. In the stack where we define the FE app
new amplifyAlpha.App(this, 'mySubAmpHosting', {
...
acmCert:{
 fromCertificateArn:`xxx`
}
})

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0 (build 9f2bdf7)

Environment details (OS name and version, etc.)

macOS Ventura - 13.6.3

@thedevopsguyblog thedevopsguyblog added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 20, 2024
@github-actions github-actions bot added the @aws-cdk/aws-amplify Related to AWS Amplify label Jun 20, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 20, 2024
@khushail
Copy link
Contributor

Hi @thedevopsguyblog , thanks for reaching out.

I see that CertificateSettings prop is supported by the cloudformation, and is missing from the alpha module. This prop support providing AWS managed or Custom certificates, hence is suitable for your usecase.
However I am marking this issue as P3, requesting contributions from the community in this regard.

@khushail khushail added p3 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 20, 2024
@mergify mergify bot closed this as completed in #30791 Aug 14, 2024
@mergify mergify bot closed this as completed in 8d76778 Aug 14, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.